Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #26 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 6 +1
Lines 146 188 +42
=========================================
+ Hits 146 188 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mengelbart
force-pushed
the
feat/arrival-groups
branch
2 times, most recently
from
6c2ab27 to
4412501
Compare
mengelbart
force-pushed
the
feat/arrival-groups
branch
from
4412501 to
376aab4
Compare
JoTurk
reviewed
Mar 4, 2026
| return nil | ||
| } | ||
|
|
||
| sendTimeDelta := departure.Sub(a.next[0].Departure) |
Member
There was a problem hiding this comment.
shouldn't this be the last packet? not the first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the arrival group pre-filter described in https://datatracker.ietf.org/doc/html/draft-ietf-rmcat-gcc-02#section-5.2